docs(AGENTS): prefer Rrbvec over O(n²) List concat patterns - #35
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2e6ce936b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| A representative core action is the Swift FFI RPC `dispatch` / `send`, which optimistic-captures a journal block (see `shared/test/logseq_chat/rpc_test.ml` and `dune build @shared/native/runtest`). | ||
|
|
||
| - Avoid O(n²) `List` patterns such as `List.concat` and repeated `List.append` on large sequences; when the project already depends on the `rrbvec` package, use `Rrbvec` vectors instead. |
There was a problem hiding this comment.
For a large list of lists, a single List.concat traverses each element once and is linear in the total input/output size; it does not have the quadratic behavior of repeatedly appending an ever-growing accumulator. Labeling List.concat itself as an O(n²) pattern directs future contributors to replace an appropriate standard-library operation with unnecessary vector conversions or dependencies. Limit this guidance to repeated/nested append patterns that actually retraverse accumulated data.
Useful? React with 👍 / 👎.
1 participant
Summary
AGENTS.md: avoid O(n²)Listpatterns such asList.concatand repeatedList.appendon large sequences; when the project already depends on therrbvecpackage, useRrbvecvectors instead.Link to Devin session: https://app.devin.ai/sessions/cc13a6a77cdd40f89ea6695bff8ff7eb
Open in Devin Desktop: https://app.devin.ai/desktop/session/cc13a6a77cdd40f89ea6695bff8ff7eb?variant=devin
Requested by: @RCmerci